fix: #2940 emit RealtimeHistoryUpdated on transcript_delta#3086
Open
Quratulain-bilal wants to merge 2 commits intoopenai:mainfrom
Open
fix: #2940 emit RealtimeHistoryUpdated on transcript_delta#3086Quratulain-bilal wants to merge 2 commits intoopenai:mainfrom
Quratulain-bilal wants to merge 2 commits intoopenai:mainfrom
Conversation
When RealtimeSession received a RealtimeModelTranscriptDeltaEvent, it accumulated transcript text into self._history but only forwarded the raw model event. Subscribers that follow the documented history_added / history_updated pattern never observed the live transcript update. Emit RealtimeHistoryUpdated after the history mutation, matching the input_audio_transcription_completed branch, and update the session test that asserted transcript_delta was an ignored event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history_updatedfortranscript_delta#2940.RealtimeSessionpreviously updatedself._historyontranscript_deltaevents but only forwarded the raw model event, sosubscribers following the documented
history_added/history_updatedpattern missed live transcript updates.
RealtimeHistoryUpdatedafter the history mutation, mirroring theinput_audio_transcription_completedbranch.transcript_deltawas an ignoredevent, and added a new test asserting the event now emits
RealtimeHistoryUpdated.Test plan
uv run pytest tests/realtime/test_session.py— 66 passed